toggle fullscreen button for ImageDisplay #1803
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rhaschke
force-pushed
the
image-display-full-screen
branch
from
b2578cc
to
697194c
Compare
rhaschke
merged commit 6ca7e79
into
ros-visualization:noetic-devel
8 of 9 checks passed
|
With a single display, it works well. However, it struggles on my multi-monitor setup: image_maximize.mp4You can see the behavior is not consistent on multiple retries. My monitor setup:
xrandr excerpt: The same happens even when I align the top of display 2 with the top of display 3. |
|
@peci1, I'm afraid that's an Qt issue (which we cannot resolve). |
|
Okay, it's nothing horrible ;) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
implementation for #1802